Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix state vector factorization validation #5076

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Fix state vector factorization validation #5076

merged 1 commit into from
Mar 14, 2022

Conversation

daxfohl
Copy link
Contributor

@daxfohl daxfohl commented Mar 13, 2022

The validate block here did not account for the possibility of a phase shift. It was just luck that H(q0), I(q1) factorization in the test did not cause one. Also there's no need to transpose the axes here, just compare t1 and t2 directly.

@daxfohl daxfohl requested review from a team, vtomole and cduck as code owners March 13, 2022 22:38
@daxfohl daxfohl requested a review from dabacon March 13, 2022 22:38
@CirqBot CirqBot added the Size: XS <10 lines changed label Mar 13, 2022
@daxfohl daxfohl mentioned this pull request Mar 13, 2022
Closed
MichaelBroughton
MichaelBroughton approved these changes Mar 14, 2022
View reviewed changes
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelBroughton MichaelBroughton self-assigned this Mar 14, 2022
@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Mar 14, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Mar 14, 2022
@CirqBot CirqBot merged commit c76bbc7 into quantumlib:master Mar 14, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Mar 14, 2022
@daxfohl daxfohl deleted the fixval branch March 14, 2022 01:11
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@daxfohl @rht
Fix state vector factorization validation (quantumlib#5076)
9eeb83d 
The `validate` block here did not account for the possibility of a phase shift. It was just luck that `H(q0), I(q1)` factorization in the test did not cause one. Also there's no need to transpose the axes here, just compare `t1` and `t2` directly.
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@daxfohl
Fix state vector factorization validation (quantumlib#5076)
fe34304 
The `validate` block here did not account for the possibility of a phase shift. It was just luck that `H(q0), I(q1)` factorization in the test did not cause one. Also there's no need to transpose the axes here, just compare `t1` and `t2` directly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelBroughton MichaelBroughton MichaelBroughton approved these changes

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@dabacon dabacon Awaiting requested review from dabacon dabacon was automatically assigned from quantumlib/cirq-maintainers

Assignees

@MichaelBroughton MichaelBroughton

Labels
Size: XS <10 lines changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daxfohl @MichaelBroughton @CirqBot